Repository navigation
fix: recover setup replies missing the final JSON brace - #75
Open
cooper (czxtm) wants to merge 1 commit into
Open
cooper (czxtm) wants to merge 1 commit into
cooper (czxtm) wants to merge 1 commit into
Conversation
Completed provider replies can omit only the outer closing brace. Recover that delimiter only after strict decoding and semantic validation, and recover saved replies before requesting another model response. Preserve frozen-plan guards and reject incomplete nested content. Fixes stackpanel-0h7.
Contributor
|
Preview deployed to |
Contributor
|
Docs preview deployed to |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed setup-agent streams can omit the final outer JSON brace, causing malformed-JSON warnings and repeated formatting requests. Recover exactly that delimiter only when strict decoding and existing semantic validation succeed. Reparse saved replies before model correction while preserving frozen plans and saved answers; incomplete nested content remains rejected.
Validation:
TMPDIR=/private/tmp go -C apps/stackpanel-go test ./internal/setupagent ./cmd/cli -count=1passed.go -C apps/stackpanel-go build ./...passed.TestInstalledCodexReplyCorrectionpassed.bun run check-types, scoped formatting/diff checks, and calldiff passed.Separate verification failures are tracked in stackpanel-jk2: existing TypeScript lint errors, the removed nixfmt-rfc-style hook in
nix flake check, and pkg/nixdata TestSetKey. The latter also fails on the original commit in a clean worktree. Canonical TMPDIR avoids additional existing macOS path-comparison failures.Fixes stackpanel-0h7.