Repository navigation
feat: Open Graph image route, feed caching, customers marquee and phone number - #140
Merged
Merged
Conversation
Next's revalidateTag/revalidatePath throw outside a Next request context, so every hook that fired in the standalone jobs worker (scheduled publishes, createResumeDocument) silently skipped invalidation and left pages stale until their cacheLife expired. - revalidateCache() calls Next directly when it can and otherwise POSTs the same tags/paths to /api/revalidate; it never throws, so a failed invalidation cannot fail the write. - /api/revalidate requires a bearer token derived from PAYLOAD_SECRET (timing-safe compare) and validates tags and same-site paths. - Collection hooks, the resume-section hook and the fetchers' revalidate* helpers go through revalidateCache.
…esh the resume UI Phone number - The user settings' `telephone` text field becomes a `phoneNumber` group: `value` is validated with libphonenumber (international format, or national with the address country) and stored as E.164; `formatted` and `uri` are derived on read. Shared helpers live in SettingsGlobalUser/phoneNumber.ts. - Migration 00000008 moves the stored `telephone` into `phoneNumber.value`. - Footer, legal publisher block, JSON-LD and the PDF header read the derived values; the links are hidden when no valid number is set, and the PDF schema checks the tel: URI as E.164 again. - Text fields in the settings are trimmed before validation. Resume UI - Reveal folds useReveal into the component and owns its styles. - The checksum validator accepts pasted PDFs and pasted SHA-256 hashes. - fetchDocumentBySlug selects only the fields it returns; the downloads block reads the latest document through it. - Experience entries show their skill tags; badge, logo tile and dropzone styling tweaks.
…d LegalAttributions Gives the two legal blocks names that say what they render, and moves the publisher block's admin hint into its own AdminInfo component like the attributions block.
Hero shaders rendered only in Storybook: each shader called WEBGL_lose_context.loseContext() in its effect cleanup, so React's Strict Mode re-run (and <Activity>) got a dead context on the same canvas. The browser frees the context once the canvas leaves the DOM. The admin now shows each preset's thumbnail.png (ShaderThumbnail) instead of live preview canvases.
extractHeadings now walks a Lexical document or a page's block list with one shared id generator: a block's title becomes a level-1 section, and a RichTextBlock's headings follow it, nested one level deeper when the block has a title. RenderBlocks hands each block its anchor ids from that single run, so ids stay unique across the page; ids are slugified with dashes. The scroll-spy logic from TableOfContents moves into useScrollSpy, which SectionNavigation now uses directly. The navigation context, provider, display component and portal-host hook are gone, and SectionContainer is a plain server-compatible section. RichText takes the precomputed heading ids, and also gains a renderedBlocks prop for blocks whose renderers are async Server Components (serverRenderedBlockSlugs).
The page shells wrapped their content in a Suspense boundary without a fallback, so during a navigation that had to load the new page its segment rendered nothing. Next scrolls to the new page's first rendered element; with none it skipped the scroll and the reader kept the previous page's offset. PageFallback gives the boundary a full-height element to scroll to.
…youts A page is now either richText - a content rich-text field rendered like a blog post - or sections, the former blocks field (now sections). Both blog posts and rich-text pages render through the new ArticleLayout: content column plus a sidebar with the table of contents and the links group, which pages gain as a Links tab. - Resume blocks are offered only on the resume page, which alone gets the section navigation. - The legal blocks lose their title field and move into rich text. Lexical cannot offer blocks per document, so validation rejects them outside legal-notice and privacy-policy. Their async renderers are pre-rendered by renderServerBlocks and handed to RichText by block id. - Migration 00000009 converts pages and their versions: the legal pages become rich text (old block titles become h2 headings above the embedded blocks), every other page keeps its blocks as sections. - Seeds, the initial migration and the resume revalidation hook use the new layout values; the resume page is matched by slug. - fetchPageBySlug defaults to the home slug.
The 404 heading and button sat below the hero video. DuoTone's stylesheet was unlayered, so it beat Tailwind utilities and its contained variant's relative overrode HeroMedia's absolute inset-0; that variant also kept the base display: contents, so the wrapper had no box at all. The media stayed in flow at its natural height and pushed centred content down. The rules now live in @layer components, and the contained variant is a real block box.
The hero media always renders as the blue duotone, so text on it is now white in both themes: HeroMedia sets it on its overlaid content and marks its section with data-hero, and the header turns white while a hero is present (including the nav links, whose button styles read --color-foreground). An eased gradient (tw-easing-gradients) fades from the brand blue at the top of the hero to keep the header readable over bright media, and the header logo is a step larger than the navigation text.
SERVER_URL is a required URL in the env schema that next.config.ts enforces at startup, so the fallbacks were dead code - including the deprecated danielheene.de domain on blog posts. The blog post's structured-data URL now points at the real /blog/post/<slug> route instead of /posts/<slug>.
Turbopack's dev server kept failing with a stale client-reference error (Slug FieldComponent) after edits to modules the frontend layout imports.
ImageMedia resolves relative sources against NEXT_PUBLIC_SERVER_URL, gives fill images a positioned wrapper so next/image stops warning, and uses a per-instance blur filter id. Drops leftover debug logging in both media components.
Previews get responsive images and the blur-up placeholder. Videos with a known file now preview as video with their poster frame, and the shader thumbnails load through ImageMedia as well.
Rows of customer logos, each row shuffled server-side inside the cache, scroll diagonally behind a centred 16:9 panel holding the title and caption. Rows size themselves to cover the section at any width.
The feed now sends ETag, Last-Modified and Cache-Control, so readers that already hold the current version revalidate instead of downloading it again.
Site name, category, host and URL fall back to their defaults when read instead of being stored, so the initial migration no longer seeds them. The meta title is read-only and regenerated on read.
Cards share one template: the hero (image, video poster or shader thumbnail, falling back to the site default) in the brand duotone, the logo and site address on top, topic badges or a label, the title in PP Supply Sans and the meta description in PP Frama, rendered as JPEG. The route takes a path or a collection and slug, so any card can be previewed; page metadata links it with a version so the URLs can be cached for good. This also gives /resume a working image again, which the resume folder used to shadow. The published-topic query moves to the fetchers, and the resume document description becomes a shared helper, so pages and cards use the same text.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Previous Review Summaries (3 snapshots, latest commit c6cc6db)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit c6cc6db)Status: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Previous review (commit 7e7f863)Status: No Issues Found | Recommendation: Merge Files Reviewed (27 files)
Previous review (commit 137e50c)Status: No Issues Found | Recommendation: Merge Files Reviewed (27 files)
Reviewed by free · Input: 0 · Output: 0 · Cached: 0 |
Pages now emit a single @graph whose nodes reference the site-wide Person, WebSite and Blog by @id instead of unrelated copies. - Person: the address uses PostalAddress properties, the portrait appears (image uploads are recognized by URL, since their populated form omits mimeType), givenName and familyName are added, and birth date and gender are no longer published. - WebSite: the default image appears and the person is its publisher. - Blog posts render their BlogPosting and breadcrumb, which were built but never output, now with description, topics, word count, reading time, hero and card images, and a trail through the primary topic. - Images carry their pixel size and stored credits as creditText. - The unused Organization, SoftwareSourceCode and CollectionPage generators are removed.
…documents - Home and resume are ProfilePages about the site owner; the resume adds the jobs held, skills and projects to the person. - Other CMS pages are WebPages with a breadcrumb. - The blog and topic listings are CollectionPages listing their posts. - Resume documents are DigitalDocuments with each language's PDF, its SHA-256 checksum and size.
/resume is a pages document; resume-documents only serves the PDFs under /resume/<slug>.
danielheene-website-release Bot
pushed a commit
that referenced
this pull request
Nov 19, 2026
# [1.17.0-rc.3](v1.17.0-rc.2...v1.17.0-rc.3) (2026-11-19) ### Features * Open Graph route, structured data, feed caching, customers marquee and phone number ([#140](#140)) ([3c155ed](3c155ed))
|
🎉 This PR is included in version 1.17.0-rc.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open Graph images
/api/og-image, replacing the sevenopengraph-image.tsxfiles.?path=/blog/post/my-post) or a collection and slug (?collection=posts&slug=my-post), so any card can be previewed in the browser.vversion taken from the document's last change. Those URLs are cached asimmutable; previews withoutvareno-cache./resumehas a working card again; the resume folder used to shadow it.src/lib/fetchers/.Logocomponent and the card template.RSS feed
/blog/feed.xmlsendsETag,Last-ModifiedandCache-Control, and answers conditional requests with 304. Readers that already have the current feed no longer download all of it again.Customers and media
ImageMediaandVideoMedia, so they get responsive images and blur-up.ImageMediaresolves relative URLs and positions fill images correctly.Structured data (JSON-LD)
@graph. The site-widePerson(/#person),WebSite(/#website) andBlog(/blog#blog) each exist once; every other node points at them by@id.Person: the address usesPostalAddressproperties, and the portrait now appears.Person:givenNameandfamilyNameare added, and birth date and gender are no longer published.WebSite: the default image now appears, and the person is its publisher.mimeType. That had hidden every image.BlogPostingand breadcrumb; before, both were built but never output./is aProfilePageabout the owner./resumeis also aProfilePage, and adds the jobs held, skills and projects to the person.WebPagewith a breadcrumb./blogand/blog/<topic>areCollectionPages listing their posts./resume/<doc>is aDigitalDocumentwith each language's PDF, its SHA-256 checksum and size./resume:/resumeis a document in the pages collection (slugresume,RESUME_PAGE_SLUG). The resume-documents collection only serves the generated PDFs under/resume/<slug>. The resume page's structured data therefore comes from the page route,app/(frontend)/[slug]/page.tsx, which adds the career nodes when the slug isresume.Organization,SoftwareSourceCodeandCollectionPagegenerators are removed.Earlier commits on this branch
/api/revalidate.extractHeadings.SERVER_URLfallbacks.AGENTS.mdlists the newer scripts.Verification
bunx tsc --noEmitis clean, andbun run testpasses all 1,042 tests (126 files).bun run buildsucceeds. It also prints "Compiled with warnings" without listing them; that cause isn't looked into here..next/standalone, and the standalone server rendered a card.og:imagetag, and each of those image URLs returns a JPEG.