Skip to content

Fix skipped tests on same-repository pull requests - #95

Merged
mcflugen merged 1 commit into
csdms:masterfrom
mcflugen:tidy-up-ci
Oct 20, 2026
Merged

mcflugen merged 1 commit into
csdms:masterfrom
mcflugen:tidy-up-ci

Conversation

@mcflugen

Copy link
Copy Markdown
Member

I've fixed an issue where same-repository pull requests skipped the build job, which also skipped the dependent test job, and so the tests-passed check failed because testing had not succeeded. We should always be working from forks anyway, but dependabot creates branches on the repository so that's where the issue came up.

I've also tidied the workflow up a bit.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.84%. Comparing base (6dacc71) to head (ebda7f3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files          10       10           
  Lines         371      371           
=======================================
  Hits          363      363           
  Misses          8        8           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcflugen
mcflugen merged commit 0e7acc7 into csdms:master Oct 20, 2026
22 checks passed
@mcflugen
mcflugen deleted the tidy-up-ci branch October 20, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants