Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 97.84% 97.87% +0.03%
==========================================
Files 10 11 +1
Lines 371 377 +6
==========================================
+ Hits 363 369 +6
Misses 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mcflugen
force-pushed
the
disambiguate-version
branch
2 times, most recently
from
October 20, 2026 15:31
32f4af4 to
f02efda
Compare
mcflugen
force-pushed
the
disambiguate-version
branch
from
October 20, 2026 18:15
f02efda to
661a1ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @mdpiper has voiced, the similar bmipy and BMI version numbers can make it unclear which identifies the package release and which identifies the supported BMI specification.
I've made some changes that I hope make this more clear and will also allow for supporting additional BMI specifications. For example, a preliminary BMI 3.0 (I imagine this will be in
bmipy.bmi3_0_draftor something similar).bmipy.bmi2_0as the explicit import for BMI 2.0. This contains theBMI_VERSIONconstant alongsideBmithat gives the supported BMI version.bmipy.bmiimports for backward compatibility.