Skip to content

Distinguish bmipy package and BMI specification versions - #91

Open
mcflugen wants to merge 1 commit into
csdms:masterfrom
mcflugen:disambiguate-version
Open

mcflugen wants to merge 1 commit into
csdms:masterfrom
mcflugen:disambiguate-version

Conversation

@mcflugen

Copy link
Copy Markdown
Member

As @mdpiper has voiced, the similar bmipy and BMI version numbers can make it unclear which identifies the package release and which identifies the supported BMI specification.

I've made some changes that I hope make this more clear and will also allow for supporting additional BMI specifications. For example, a preliminary BMI 3.0 (I imagine this will be in bmipy.bmi3_0_draft or something similar).

  • Use bmipy.bmi2_0 as the explicit import for BMI 2.0. This contains the BMI_VERSION constant alongside Bmi that gives the supported BMI version.
  • I've kept package-level and bmipy.bmi imports for backward compatibility.

@mcflugen
mcflugen requested a review from mdpiper October 20, 2026 02:49
@codecov-commenter

codecov-commenter commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.87%. Comparing base (10353e4) to head (661a1ec).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   97.84%   97.87%   +0.03%     
==========================================
  Files          10       11       +1     
  Lines         371      377       +6     
==========================================
+ Hits          363      369       +6     
  Misses          8        8              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcflugen
mcflugen force-pushed the disambiguate-version branch 2 times, most recently from 32f4af4 to f02efda Compare October 20, 2026 15:31
@mcflugen
mcflugen force-pushed the disambiguate-version branch from f02efda to 661a1ec Compare October 20, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants