Repository navigation
Fix HSL example values on Color field page - #795
Closed
brandonkelly wants to merge 1 commit into
Closed
brandonkelly wants to merge 1 commit into
brandonkelly wants to merge 1 commit into
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a19d9b-8349-7497-bd3b-8f66b3f74fda Co-authored-by: Amp <amp@ampcode.com>
✅ Deploy Preview for craft-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
I was in the middle of some other Color field cleanup on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Color field page's
ColorDataexamples gave the wrong HSL values for#e5422b:The new values match the
hsla(7,78%,53%,0.5)example added for 5.12 (#794).Evidence
I ran the RGB→HSL math in
craft\fields\data\ColorData::_hsl()onrgb(229,66,43)and got[7, 78, 53].