Skip to content

fix: keep the deadset analyzer pins on the 2.0 dev builds - #345

Merged
cplieger merged 2 commits into
mainfrom
feat/deadset-dev-prereleases
Nov 5, 2026
Merged

cplieger merged 2 commits into
mainfrom
feat/deadset-dev-prereleases

Conversation

@cplieger

@cplieger cplieger commented Nov 2, 2026

Copy link
Copy Markdown
Owner

The "deadset analyzers" Renovate group for .github/workflows/deadset-ci.yaml in cplieger/ci follows the deadset 2.0 dev builds.

  • matchDepNames moves to the /v2 Go module paths, github.com/cplieger/deadset/v2 and github.com/cplieger/deadset-go/v2, beside @cplieger/deadset-ts.
  • ignoreUnstable: false lets a dev build on a later version through. Renovate's default keeps an unstable candidate only at the current major, minor and patch.
  • allowedVersions: /^v?\d+\.\d+\.\d+-dev\.\d+$/ keeps all three pins on the dev line. Semver ranks a stable X.Y.Z above every X.Y.Z-dev.N, so without it the first stable release would move the two Go pins off the dev line while deadset-ts stays on its dev tag.
  • respectLatest: false lets a dev build newer than the registry's latest through.
  • A second rule gives deadset-ts alone followTag: "dev". The go datasource has no dist-tags, and Renovate proposes no update for a dep whose followTag it cannot find.

When deadset 2.0 ships stable, the change that moves deadset, deadset-go and deadset-ts to stable together also removes this allowedVersions.

This merges right after cplieger/ci#907, which moves the pins to the /v2 paths. Merged earlier, the old 1.x names would match nothing and deadset-ts would open a lone dev bump.

Tested with Renovate 44.199.2: renovate-config-validator --strict passes, and a misspelled key fails it. applyPackageRules gives the three pins the group, ignoreUnstable, respectLatest and automerge, and gives only deadset-ts followTag. Controls get none of these: deadset-ts in a package.json, the old 1.x module path and golangci-lint. filterVersions with the rule applied keeps only dev candidates for each pin and drops v2.0.0 and 8.0.0. With allowedVersions removed, the stable candidates come back.

The "deadset analyzers" group in cplieger/ci's deadset-ci.yaml now matches the /v2 Go module paths, turns ignoreUnstable and respectLatest off, and admits only X.Y.Z-dev.N versions, so the three pins move together along the 2.0 dev builds. deadset-ts follows its npm dev dist-tag in its own rule, because the go datasource has no dist-tags.

Checks: renovate-config-validator --strict (Renovate 44.199.2) validated; applyPackageRules and filterVersions over the three deps match the intended candidates, with controls unchanged.
@cplieger
cplieger marked this pull request as draft November 2, 2026 10:06
@cplieger
cplieger marked this pull request as ready for review November 5, 2026 16:41
@cplieger
cplieger merged commit 75be827 into main Nov 5, 2026
18 checks passed
@cplieger
cplieger deleted the feat/deadset-dev-prereleases branch November 5, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant