Repository navigation
land: restore-asks-per-file - #552
Merged
Merged
Conversation
Use the existing checkpoint_paths preview for the shared OpenCode V1/V2 edit ask, before dispatching any restore writes. Preserve host rule-denial details so the deciding path reaches the caller. Add real-bridge deny/allow/ask coverage for exact checkpoint files, atomic refusal, and deleted-file recreation. Pi has no host edit-rule engine; preserve its existing behavior and cover preview-based project-root isolation without introducing prompts. Verified plugin typechecks/lint, targeted safety/V2/publication suites, pre-fix red tests and two mutation controls. Full plugin runs also exercised unrelated deadline/environment failures; targeted deadline reruns passed and the search audit failure reproduced on base code. Details: .cortexkit/internal-docs/investigations/issue-541/verification.md (delivery artifact). Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepted agent delivery; branch-keyed search descriptor included.
Summary by cubic
Checkpoint restore now asks for edit permission per checkpoint file instead of workspace-wide, so path-based deny/allow/ask rules apply per file and a denied file blocks the restore.
path,file, orfiles; the permission ask and preview then target only the selected files, withfile://URL paths resolved.Written for commit 379b79f. Summary will update on new commits.
The PR appears safe to merge; no new actionable issues were found.Summary
Checkpoint restores now ask for edit permission only on the files being restored.
Reviews (3) · Last reviewed commit: "mason: resolve file URLs for restore pre..." · Reviewed by Greptile