Repository navigation
land: gh-shim-rename-guard - #549
Merged
Merged
Conversation
Refuse published reusable workflows/actions and unverified inspections before audited operator delegation. Resolve the existing repository through real gh, inspect one bounded default-branch tree, parse workflow YAML, and provide an exact audited override. The v19 classifier bypass test now explicitly opts into the rename override: unconditional bypass admission is no longer safe. Extend the closed refusal-code set for the two new failures. The reviewed v19 manifest stays unchanged. Verified 234 shim unit tests, 83 shim integration tests (serial to avoid an unrelated shared-env race), 182 list-envelope tests, Windows warnings-denied cross-check, and formatting. YAML-trigger and truncated-tree mutants each failed exactly their named regression test; restored suite passed all 12 controls. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
A 100 ms deadline and a 2 s elapsed bound can flake on loaded CI runners, and the grandchild test could panic if the shell had not yet recorded the pid. Deadlines of 1-3 s with a 15 s bound still prove the timeout does not wait for the 30 s descendant. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 18, 2026
…child timeout test Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepted agent delivery; branch-keyed search descriptor included.
Summary by cubic
Adds a preflight guard to operator-bypassed
repo renameso it refuses when the repository publishes reusable workflows or actions that other repositories reference, since GitHub does not redirect those references after a rename. The check fails closed when it cannot verify the repository is safe (API errors, truncated trees, unparseable workflow YAML, or limits).GH_SHIM_RENAME_PUBLISHED=allow, which still runs the bounded inspection but records the published paths or unverified reason in the operator audit.gh_shim_rename_publishedandgh_shim_rename_unverifiedare added to the closed set.Written for commit 431a7f9. Summary will update on new commits.


Confidence Score: 5/5
The PR appears safe to merge; no new actionable issue was found.Summary
Adds a preflight check before operator-bypassed
repo renameto detect reusable workflows and actions.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Operator-bypassed repo rename] --> B[Inspect repository] B --> C{Safe or explicit override?} C -->|No| D[Refuse rename] C -->|Yes| E[Write and sync audit] E --> F{Audit saved?} F -->|No| D F -->|Yes| G[Delegate to gh]Reviews (3) · Last reviewed commit: "gh-shim: leave room for nested PowerShel..." · Reviewed by Greptile