Repository navigation
fix(fetch): preserve port when matching noProxy patterns (#13366) - #13385
Open
patrickswedish wants to merge 1 commit into
Open
patrickswedish wants to merge 1 commit into
patrickswedish wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
…#13366) Signed-off-by: Patrick Ribbsaeter <patrickswedish@gmail.com>
patrickswedish
force-pushed
the
fix/fetch-noproxy-port-matching-13366
branch
from
October 15, 2026 21:44
5887011 to
f5cf295
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves the URL port during
noProxyevaluation infetchwithRequestOptionsso port-specific proxy bypass rules (such as127.0.0.1:11434orlocalhost:11434) correctly match and bypass the configured proxy.Changes
packages/fetch/src/fetch.ts, normalizeurl.hostname(preserving any port onurl.host) and passurl.host(andoriginalHost) toshouldBypassProxy.packages/fetch/src/util.test.ts, add unit tests verifying port discrimination for IP and localhostnoProxyrules.Fixes #13366
Diff minimization and pre-flight validation performed with ZeroSlop™ CI — Ribbsaeter Systems.