Repository navigation
Improve NotifyComp local development and mobile activity labels - #98
Merged
Merged
Conversation
✅ Deploy Preview for competition-groups ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local Vite development now forwards NotifyComp token requests to the deployed production function, with an optional
NOTIFY_COMP_TOKEN_ORIGINoverride documented in the README and.env.example. Token validation and competition permissions remain handled by the deployed issuer.On mobile, the remote bar shows compact activity labels such as
5x5 R1 G2and wraps longer labels so round and group details remain visible. Desktop keeps full schedule names, and custom activities keep their existing names.Validation:
yarn check:typeyarn lint(no errors; three existing warnings in unrelated files)yarn test --runInBand(62 suites, 413 tests, and 2 snapshots passed)The local
.envis excluded from this PR.