Repository navigation
Conversation
✅ Deploy Preview for competition-groups ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A signed-in home-page reload could restore a recently cached empty personal-competitions result and skip the API request, incorrectly leaving “No competitions found” visible.
Always refresh personal competitions when the query mounts, including on home-page reloads and return visits. Keep cached competitions visible while fetching, show the loading bar during cache restoration and refreshes, and defer the empty state until refreshing finishes.
Regression tests cover restoring both empty and populated fresh caches, keeping cached data visible during a delayed request, and refetching on a return visit within the five-minute freshness window.
Validation:
yarn check:typeyarn lint(no errors; three existing warnings in unrelated files)yarn test --runInBand(62 suites, 416 tests, and 2 snapshots passed)The existing Main PR Guard permits only
betaas the source branch for PRs intomain, so it will flag this direct fix PR. No guard or deployment configuration is changed.