Repository navigation
fix: allow native DialOptions fields on Wasm - #597
Open
SilverBirchh wants to merge 1 commit into
Open
SilverBirchh wants to merge 1 commit into
SilverBirchh wants to merge 1 commit into
Conversation
DialOptions on Wasm had only Subprotocols, so code that sets HTTPClient or HTTPHeader for native builds did not compile for Wasm, and libraries supporting both had to split each Dial call behind build tags. The Wasm DialOptions now has the native fields and Dial ignores them, since the browser performs the handshake and cannot use them.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Wasm,
DialOptionsonly hadSubprotocols, so code that setsHTTPClientorHTTPHeadercompiled natively but not for Wasm. Libraries that support both, like mautrix-go, had to split eachDialcall behind build tags.This adds the native fields to the Wasm
DialOptions, asAcceptOptionsalready does.Dialignores them, since the browser does the handshake and can't use them.TestWasmDialIgnoresNativeOptionsdials with them set, and the Wasm tests pass in headless Chrome.Updates #373