Skip to content

fix(go): commit the dataflow test fixtures that .gitignore excluded - #449

Merged
rahlk merged 1 commit into
mainfrom
fix/issue-448
Nov 18, 2026
Merged

rahlk merged 1 commit into
mainfrom
fix/issue-448

Conversation

@rahlk

@rahlk rahlk commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Commits the two Go dataflow fixtures that PR #444 named but did not add, and adds a .gitignore exception for them.

Motivation and Context

The rule *.json at .gitignore:52 excluded tests/resources/go/dataflow/httpsql_l4.json and four_type_kinds.json. Without them, 52 Go tests fail with FileNotFoundError. The release workflow then deletes the tag, which is what happened to v2.2.0-rc.1 (run 44417807099).

Fixes #448.

How Has This Been Tested?

  • I generated each fixture with cango 0.3.0, from the .go.txt source beside it, with the command in tests/resources/go/dataflow/README.md. The module paths are example.com/httpsql and example.com/kinds.
  • The fixtures contain no local file-system paths.
  • uv run pytest tests/analysis/go tests/analysis/commons: 276 passed, 35 skipped, 1 failed. The one failure is test_identity_local_producers[python-…], which needs SYSTEM_PYTHON. CI sets it, so the failure is local only.
  • All 52 tests that failed in the release run now pass.

Breaking Changes

None.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the Codellm-Devkit Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

After this merges, v2.2.0-rc.1 gets tagged again on the merge commit.

Add an exception to .gitignore for tests/resources/go/dataflow/*.json, and
add the two fixtures that the tests and the README name. Each fixture is
generated with cango 0.3.0 from the .go.txt source beside it:

- httpsql_l4.json: cango -i . -a 4 --app-name httpsql --namespace httpsql
- four_type_kinds.json: cango -i . -a 1 --app-name kinds --namespace kinds

Fixes #448
@rahlk rahlk added the fix Bug fixes label Nov 18, 2026
@rahlk
rahlk merged commit 78853e6 into main Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go dataflow fixtures from #444 are not committed (.gitignore excludes *.json)

1 participant