Repository navigation
fix(go): commit the dataflow test fixtures that .gitignore excluded - #449
Merged
Merged
Conversation
Add an exception to .gitignore for tests/resources/go/dataflow/*.json, and add the two fixtures that the tests and the README name. Each fixture is generated with cango 0.3.0 from the .go.txt source beside it: - httpsql_l4.json: cango -i . -a 4 --app-name httpsql --namespace httpsql - four_type_kinds.json: cango -i . -a 1 --app-name kinds --namespace kinds Fixes #448
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits the two Go dataflow fixtures that PR #444 named but did not add, and adds a
.gitignoreexception for them.Motivation and Context
The rule
*.jsonat.gitignore:52excludedtests/resources/go/dataflow/httpsql_l4.jsonandfour_type_kinds.json. Without them, 52 Go tests fail withFileNotFoundError. The release workflow then deletes the tag, which is what happened tov2.2.0-rc.1(run 44417807099).Fixes #448.
How Has This Been Tested?
cango 0.3.0, from the.go.txtsource beside it, with the command intests/resources/go/dataflow/README.md. The module paths areexample.com/httpsqlandexample.com/kinds.uv run pytest tests/analysis/go tests/analysis/commons: 276 passed, 35 skipped, 1 failed. The one failure istest_identity_local_producers[python-…], which needsSYSTEM_PYTHON. CI sets it, so the failure is local only.Breaking Changes
None.
Types of changes
Checklist
Additional context
After this merges,
v2.2.0-rc.1gets tagged again on the merge commit.