Skip to content

Go dataflow fixtures from #444 are not committed (.gitignore excludes *.json) #448

Closed

Description

@rahlk

Describe the bug
PR #444 did not commit the two Go dataflow fixtures. The rule *.json at .gitignore:52 excludes them:

  • tests/resources/go/dataflow/httpsql_l4.json
  • tests/resources/go/dataflow/four_type_kinds.json

The fixture README (tests/resources/go/dataflow/README.md) and 52 tests read these files. Without them, make test fails, and release.yml deletes the release tag.

To Reproduce
Steps to reproduce the behavior:

  1. Clone main at de642a3.
  2. uv sync --all-groups --frozen
  3. uv run pytest tests/analysis/go/test_go_dataflow.py tests/analysis/go/test_go_analysis.py -q --no-cov
  4. Result: 6 failed, 46 errors, each with FileNotFoundError: .../tests/resources/go/dataflow/httpsql_l4.json (or four_type_kinds.json).

Expected behavior
Both fixtures are in the repository, and the Go dataflow and model tests pass.

Logs

E       FileNotFoundError: [Errno 2] No such file or directory: '.../tests/resources/go/dataflow/httpsql_l4.json'
E       FileNotFoundError: [Errno 2] No such file or directory: '.../tests/resources/go/dataflow/four_type_kinds.json'
$ git check-ignore -v tests/resources/go/dataflow/httpsql_l4.json
.gitignore:52:*.json	tests/resources/go/dataflow/httpsql_l4.json

Additional context

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions