You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Go dataflow fixtures from #444 are not committed (.gitignore excludes *.json) #448
Describe the bug
PR #444 did not commit the two Go dataflow fixtures. The rule *.json at .gitignore:52 excludes them:
tests/resources/go/dataflow/httpsql_l4.json
tests/resources/go/dataflow/four_type_kinds.json
The fixture README (tests/resources/go/dataflow/README.md) and 52 tests read these files. Without them, make test fails, and release.yml deletes the release tag.
To Reproduce
Steps to reproduce the behavior:
Clone main at de642a3.
uv sync --all-groups --frozen
uv run pytest tests/analysis/go/test_go_dataflow.py tests/analysis/go/test_go_analysis.py -q --no-cov
Result: 6 failed, 46 errors, each with FileNotFoundError: .../tests/resources/go/dataflow/httpsql_l4.json (or four_type_kinds.json).
Expected behavior
Both fixtures are in the repository, and the Go dataflow and model tests pass.
Logs
E FileNotFoundError: [Errno 2] No such file or directory: '.../tests/resources/go/dataflow/httpsql_l4.json'
E FileNotFoundError: [Errno 2] No such file or directory: '.../tests/resources/go/dataflow/four_type_kinds.json'
Fix: add an exception such as !tests/resources/go/dataflow/*.json to .gitignore, then commit the two files. The README gives the cango 0.3.0 command for each.
This blocks v2.2.0-rc.1. The release workflow runs make test and deletes the tag on failure.
Activity