Repository navigation
Remember collapsed state of Show EntityList & Dashboard fields - #791
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
EntityList and Dashboard fields in a Show page always came back with their default collapsed state (
collapsable) when navigating back, even thoughonToggle()wroteremembered.collapsed. Thecollapsedref was initialized from props beforeuseRememberand never read the remembered value back (// TODO handle remembered collapse state).Fix
useRememberfirst (defaultcollapsed: props.collapsable) and initializecollapsedfromremembered.value.collapsed.props.collapsable, so a non-collapsable field can't start collapsed.highlightedInstanceIdstill forces the list open.Note: since this relies on Inertia history state, the collapsed state also persists across a page refresh.
🤖 Generated with Claude Code