Repository navigation
Fix command JSON responses downloaded as a file when Content-Type has a charset - #790
Merged
Merged
Conversation
Blob.type holds the full Content-Type header, so a reply sent as "application/json; charset=utf-8" (e.g. on Laravel Cloud) was treated as a file and downloaded instead of being handled as a command response. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aguingand
force-pushed
the
fix-blob-content-type-with-charset
branch
from
October 21, 2026 12:29
f1cdb3a to
b13cd98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some hosts (e.g. Laravel Cloud), JSON responses are sent with
Content-Type: application/json; charset=utf-8. Since commands are posted withresponseType: 'blob',Blob.typeholds the full header, so the strict!== 'application/json'check inCommandManagertreated the response as a file and downloaded it asdownload.json.This adds a
blobHasMimeType()helper that compares only the MIME type (ignoring parameters and case), used in:CommandManager::handleCommandApiResponse()application/jsonandtext/htmlblob checks)🤖 Generated with Claude Code
Close #785