Repository navigation
fix(errors): group catch-all captures by error type - #1183
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugsnag group 6a7b33b (
receiveCashLink, 411 events) holds eight error types. Catch-all captures that pass noid:group on#fileID:#functiononly, so every error thrown in one function lands in one group. This is Decision 4 (iOS half) indocs/specs/bugsnag-cleanup.md, from the triage brief.claude/plans/2026-10-30-bugsnag-6a7b33b.mdondocs/bugsnag-cleanup-triage.The fold is in
ErrorReporting.capture, not at the call sites. A newErrorReporting.groupingHashappends the error's type and value whenid:is nil, so every existing catch-all gets split without editing each one. An explicitid:still replaces it, so sites that already pick their own id keep their current groups.Associated values do split groups:
grpcStatus(13)andgrpcStatus(14)get different hashes.ErrorSubmitIntentprints the status code, and INTERNAL and UNAVAILABLE are different problems. This matches the event title, which already uses"\(error)". The cost is that an error whose description embeds free-form text would fragment into one group per message. I did not audit every error type for that.Severities are unchanged:
ErrorFetchBalance.notFoundstays.infoand transient RPC errors stay suppressed. Existing catch-all groups will start fresh on the first release with this change, so old groups need closing as superseded.ErrorReportingGroupingTestscovers different types, same error, differing associated values, different functions, and explicitid:.