Repository navigation
Pin orkes-conductor-queues to 2.0.0.rc2 (CxODEV-2125) - #10
Merged
Merged
Conversation
Conductor 3.31.0 and later bundle orkes-conductor-queues 2.0.0.rc3. Its new background poller has a race: wakePoller() can cancel a backoff poll that is already running, so two poll chains share one slot. When demand drops, both release it and the slot count goes to -1. From then on the queue never polls Redis again until the JVM restarts, with no error and a healthy /health. The JOIN queue is hit first, because an unfinished JOIN is re-queued at offset 0. The upstream fix, orkes-io/orkes-queues#30, is not released. rc2 has no background poller and is what 3.30.x shipped. 3.32.5 uses only ConductorQueue, QueueMessage and the three-argument queue constructors, and rc2 has them unchanged. The pin is listed with the other hard pins in AGENTS.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins orkes-conductor-queues to 2.0.0.rc2. This is a CxODEV-2125 follow-up to the 3.32.5 release (
server-3.32.5-rmq-kafka). The image from this change would beserver-3.32.5-rmq-kafka.1.Why
wakePoller()can cancel a backoff poll that is already running, so two poll chains share one slot./healthstays up.server-3.32.5-rmq-kafka.QueueMonitorfetches on the caller's thread. It is the version 3.30.0–3.30.2 shipped.Compatibility (checked)
ConductorQueue,QueueMessageand the three-argumentConductorRedisQueue/ConductorRedisClusterQueueconstructors. rc2 has them unchanged.JedisCommands(redis-api), which rc2 calls, has the same methods in 3.30.2 and 3.32.5.Tested
orkes-conductor-queues-2.0.0.rc2.jar.server-3.32.5-rmq-kafka, with the same suite commit.:conductor-redis-persistence:testpassed 63/63, andspotlessCheckis green.:conductor-test-harness:test. It hardcodeslocalhostfor its Redis container, which my containerised Gradle can't reach. This PR's CI runs it.PINNEDcomment and the AGENTS.md row are the guard.🤖 Generated with Claude Code