Repository navigation
Update idle handler to avoid unhandled promise rejections - #52
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix preserves existing behavior and has no identified blocking issues; tests were not executed.
No open issues 🎉
What changed in this PR
Prevents unhandled Promise v3 rejections during SSH SOCKS connection cancellation while preserving the connection’s rejection behavior.
Changes:
- Handles rejection in the idle cleanup handler.
- Adds an integration test for cancellation before SSH startup completes.
| File | Description |
|---|---|
| tests/IntegrationSshSocksConnectorTest.php | Tests rejection when a pending connection is cancelled. |
| src/SshSocksConnector.php | Ignores idle cleanup rejection to prevent unhandled rejection reports. |
Review effort: Balanced
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the idle handler to avoid unhandled promise rejections. Cancelling a connection attempt before the SSH client process is ready, for example due to a timeout, would previously report an unhandled promise rejection with Promise v3. The connection attempt still rejects as before, and the new test covers this for the
SshSocksConnectorjust like it already does for theSshProcessConnector.Builds on top of reactphp/promise#248, #35, #50 and #8