Repository navigation
#373 - Finalize the initialized tasks when the process fails - #379
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #373.
ProcessManagernow finalizes the tasks (FinalizableTaskInterface::finalize()) when the process fails too, so that a long-running worker (Messenger, UI bundle) no longer keeps the resources of a failed process open (files of the CSV / JSON stream / XML tasks, cursor ofdoctrine_database_reader).initialize()failed, nor the tasks not reached), each one only once (a failure after the normal finalization does not finalize again).finalize()can check$state->getProcessHistory()->isFailed()to skip footers / publishing on failure.StatCounterTasklogs its count when the process fails too.UPGRADE.md: newv5.6section.Requirements
Breaking changes
None for working processes: the success path is unchanged. Contract change of
FinalizableTaskInterface::finalize(), now also called when the process fails (seeUPGRADE.md): a customfinalize()must not assume the data are complete.🤖 Generated with Claude Code