Repository navigation
Smooth gradients - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had two places where we were linearly interpolating; one in the thermo solve and once in the abundance call. The thermo solve now uses dense output and the built-in diffrax hermite interpolater, as well as a new keyword argument
n_outwhich sets the number of points used for the interpolation. Keeping that at 512 doesn't substantially impact our runtime so that's default, though for work using gradients it needs to be 1024 or even higher (cost is 0.1s on M1 mac atn_out=4096).Switched from linear to log interpolation in abundances for better accuracy there as well.