Repository navigation
Conversation
Ticket: ENT-14692 Signed-off-by: Victor Moene <victor.moene@northern.tech> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reference check of a new watcher is now done by WatcherRegister(), without holding the registry lock as it may block. If it fails, the watcher is not registered and WatcherRegister() returns false, so that the events promise fails. Ticket: ENT-14692 Signed-off-by: Victor Moene <victor.moene@northern.tech> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
WatcherRegister() now takes a pointer to the options, which include the interval between two checks. Ticket: ENT-14692 Signed-off-by: Victor Moene <victor.moene@northern.tech> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ticket: ENT-14692 Signed-off-by: Victor Moene <victor.moene@northern.tech> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It sets the seconds between two checks for the event, 1 by default. The parser only checks it if it doesn't depend on variables or body arguments, so it is checked again once expanded, and the events promise fails if it is invalid. Ticket: ENT-14692 Signed-off-by: Victor Moene <victor.moene@northern.tech> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Moved from a hardcoded and single `file_deleted` event type, to a table with all the event types and their necessary code, so that cf-reactor can easily be extended with new event types. Ticket: ENT-14692 Signed-off-by: Victor Moene <victor.moene@northern.tech> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Moved file_deleted event type test to file_watcher_test - Added test coverage for watcher Signed-off-by: Victor Moene <victor.moene@northern.tech>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
cf-reactor.SyntaxCheck
branch
from
October 16, 2026 13:14
b9e9130 to
d9e7491
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.