Repository navigation
Conversation
The cachet:beacon command exits with code 1 when the beacon is disabled, and the scheduler logs every non-zero exit as an error. With CACHET_BEACON=false, every installation got a "Scheduled command [...] cachet:beacon failed with exit code [1]" error in its log each day. Only run the scheduled event when the beacon is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CACHET_BEACON=false, the scheduler logs an error every day:cachet:beacondeliberately returns1when the beacon is disabled (covered bySendBeaconCommandTest), but the scheduled event runs regardless of the setting, and the scheduler treats a non-zero exit code as a failurecachet.beaconis enabled, using->when()like the demo mode seeders below it. The command and its exit code are unchanged, and the event is still registered, soregisters the package schedules by defaultkeeps passingValidation
mainfor the disabled case and passes with the fixvendor/bin/pest: 1151 passed (4292 assertions)vendor/bin/pint --test: passedvendor/bin/phpstan analyse src/CachetCoreServiceProvider.php: no errors