Skip to content

feat: auto-approve PRs from notecard-schema #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdlauer merged 2 commits into from
Sep 28, 2026
Merged

feat: auto-approve PRs from notecard-schema #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e46677b
auto-approve PRs from notecard-schema
rdlauer Sep 28, 2026
8b44357
don't let Coveralls failures gate merges
rdlauer Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/python-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,15 @@ jobs:
# as the same job for the same commit and Coveralls 422s all but one --
# intermittently failing the build (PR #185). Coverage is the same on every
# version, so publishing from one is no loss.
#
# continue-on-error: coverage reporting must never gate a merge. Without
# it a Coveralls outage (a 500 on 2026-09-28) fails this job, fail-fast
# cancels the rest of the matrix, and the required `ci-gate` goes red.
- name: Publish to Coveralls
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
if: ${{ inputs.coveralls && matrix.python-version == '3.12' }}
continue-on-error: true
run: |
pipenv run coveralls --service=github

Expand Down
16 changes: 14 additions & 2 deletions .github/workflows/update-notecard-schema.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,10 @@ jobs:
# to approve at all, so main's 1-review rule still needs a human -- unless
# that rule is moved to a ruleset that this App bypasses.
- name: Enable auto-merge
if: ${{ steps.pr.outputs.branch != '' && steps.changes.outputs.automerge_safe == 'true' && steps.app-token.outputs.token != '' }}
if:
${{ steps.pr.outputs.branch != '' &&
steps.changes.outputs.automerge_safe == 'true' &&
steps.app-token.outputs.token != '' }}
env:
GH_TOKEN: ${{ steps.app-token.outputs.token }}
PR_BRANCH: ${{ steps.pr.outputs.branch }}
Expand All @@ -159,6 +162,15 @@ jobs:
fi

- name: Report skipped auto-merge
if: ${{ steps.changes.outputs.has_changes == 'true' && steps.changes.outputs.automerge_safe != 'true' }}
if:
${{ steps.changes.outputs.has_changes == 'true' &&
steps.changes.outputs.automerge_safe != 'true' }}
run: |
echo "::notice::PR opened but auto-merge was skipped: the generator changed paths outside notecard/. Review and merge by hand."

- name: Approve (as github-actions, not the App that opened it)
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run:
gh pr review "$PR_BRANCH" --approve -b "Automated schema sync; CI
gates the merge."
Loading