Skip to content

fix(math): preserve fractional Gamma samples - #319

Open
jackiectl2 wants to merge 1 commit into
avhz:mainfrom
jackiectl2:fix-gamma-continuous-samples
Open

jackiectl2 wants to merge 1 commit into
avhz:mainfrom
jackiectl2:fix-gamma-continuous-samples

Conversation

@jackiectl2

Copy link
Copy Markdown

Gamma::sample currently casts each draw to usize before converting it back to f64, truncating a continuous distribution and producing zeros. Keep the original floating-point draw and add a regression for positive finite, non-integral samples. Add the required changelog entry.

All 114 RustQuant_math library tests passed. cargo check, build and clippy -p RustQuant_math --lib passed; clippy warnings match the exact baseline. Changed gamma.rs passes rustfmt. Workspace cargo fmt --all --check still reports pre-existing formatting differences; the whole workspace and examples were not tested.

Gamma::sample currently casts each draw to usize before converting it back to f64, truncating a continuous distribution and producing zeros. Keep the original floating-point draw and add a regression for positive finite, non-integral samples. Add the required changelog entry.
Signed-off-by: Tianlang (Jackie) Chen <305351710+jackiectl2@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant