Repository navigation
fix(math): preserve fractional Gamma samples - #319
Open
jackiectl2 wants to merge 1 commit into
Open
jackiectl2 wants to merge 1 commit into
jackiectl2 wants to merge 1 commit into
Conversation
Gamma::sample currently casts each draw to usize before converting it back to f64, truncating a continuous distribution and producing zeros. Keep the original floating-point draw and add a regression for positive finite, non-integral samples. Add the required changelog entry. Signed-off-by: Tianlang (Jackie) Chen <305351710+jackiectl2@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gamma::sample currently casts each draw to usize before converting it back to f64, truncating a continuous distribution and producing zeros. Keep the original floating-point draw and add a regression for positive finite, non-integral samples. Add the required changelog entry.
All 114 RustQuant_math library tests passed. cargo check, build and clippy -p RustQuant_math --lib passed; clippy warnings match the exact baseline. Changed gamma.rs passes rustfmt. Workspace cargo fmt --all --check still reports pre-existing formatting differences; the whole workspace and examples were not tested.