Skip to content

fix catastrophic backtracking in _ansi_escape_pat OSC 8 params #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chandan3456 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix catastrophic backtracking in _ansi_escape_pat OSC 8 params #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tabulate/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ def escape_empty(val):
|
# terminal hyperlinks
{_osc}8; # OSC opening
(\w+=\w+:?)* # key=value params list (submatch 2)
(\w+=\w+(?::\w+=\w+)*:?)? # key=value params list (submatch 2)
; # delimiter
([^{_esc}]+) # URI - anything but ESC (submatch 3)
{_st} # ST
Expand Down
12 changes: 12 additions & 0 deletions test/test_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
"""Regression tests."""

import time

from tabulate import DataRow, Line, TableFormat, tabulate

from common import assert_equal, skip
Expand Down Expand Up @@ -598,3 +600,13 @@ def test_github_escape_pipe_character():
result = tabulate([["foo|bar"]], headers=("spam|eggs",), tablefmt="github")
expected = "| spam\\|eggs |\n|:------------|\n| foo\\|bar |"
assert_equal(expected, result)


def test_osc8_link_params_no_catastrophic_backtracking():
"Regression: unterminated OSC 8 link params must not backtrack exponentially"
cell = "\x1b]8;a=" + "aaaa=" * 16
start = time.perf_counter()
result = tabulate([[cell]], tablefmt="plain")
elapsed = time.perf_counter() - start
assert_equal(cell, result)
assert elapsed < 1.0