Skip to content

chore(deps): bump ty to 0.0.89 - #2342

Merged
vdusek merged 3 commits into
masterfrom
chore/bump-ty
Oct 20, 2026
Merged

vdusek merged 3 commits into
masterfrom
chore/bump-ty

Conversation

@vdusek

@vdusek vdusek commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Bumps ty from 0.0.86 to 0.0.89. ty 0.0.87 turned on invalid-mutable-override by default, and these are the errors it reports:

  • _METADATA_TABLE, _ITEM_TABLE and _BUFFER_TABLE on the SQL storage clients: SqlClientMixin is now generic over its table models, so the subclasses no longer narrow the attributes.
  • UserData.__pydantic_extra__: annotating it as dict[str, JsonSerializable] is how pydantic documents typing extra fields, and pydantic also validates the extras against that type. ty wants the base's | None kept, which pydantic rejects when the class is defined, so this line gets a targeted ty: ignore.

✍️ Drafted by Claude Code

@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Oct 20, 2026
@vdusek vdusek self-assigned this Oct 20, 2026
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.13%. Comparing base (08e15f6) to head (192af0a).

Files with missing lines Patch % Lines
src/crawlee/storage_clients/_sql/_client_mixin.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2342      +/-   ##
==========================================
- Coverage   94.14%   94.13%   -0.02%     
==========================================
  Files         184      184              
  Lines       13644    13647       +3     
==========================================
+ Hits        12845    12846       +1     
- Misses        799      801       +2     
Flag Coverage Δ
unit 94.13% <96.15%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek marked this pull request as ready for review October 20, 2026 08:25
@vdusek
vdusek requested a review from Mantisus October 20, 2026 08:25

@Mantisus Mantisus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apify-approval-mirror apify-approval-mirror Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirroring approval from @Mantisus.

@vdusek
vdusek merged commit 211e6e5 into master Oct 20, 2026
48 checks passed
@vdusek
vdusek deleted the chore/bump-ty branch October 20, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants