Repository navigation
fix!: swallow and warn when setting the status message fails - #1200
Open
vladfrangu wants to merge 1 commit into
Open
vladfrangu wants to merge 1 commit into
vladfrangu wants to merge 1 commit into
Conversation
`Actor.set_status_message()` no longer raises when the run update fails. It logs a warning and returns `None`, the same value it returns locally, and abandons an update that takes longer than one second. This matches the JavaScript SDK (apify/apify-sdk-js#807). BREAKING CHANGE: `Actor.set_status_message()` returns `None` instead of raising when the run update fails or times out, and logs a new warning `Failed to set status message for Actor run with ID "..."`. Closes #1199
github-actions
Bot
added
the
t-tooling
apify-service-account
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1200 +/- ##
==========================================
+ Coverage 89.89% 93.29% +3.39%
==========================================
Files 54 54
Lines 3691 3698 +7
==========================================
+ Hits 3318 3450 +132
+ Misses 373 248 -125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actor.set_status_message()no longer raises when the run update fails. It logs a warning and returnsNone, the same value it returns locally, and abandons an update that takes longer than one second. This matches the JavaScript SDK (apify/apify-sdk-js#807).RuntimeErroron the platform is kept, since it marks a broken environment rather than a transient API failure.exit()guard around the terminal status message is untouched.BREAKING CHANGE:
Actor.set_status_message()returnsNoneinstead of raising when the run update fails or times out, and logs a new warningFailed to set status message for Actor run with ID "...".Closes #1199
[🤖] Claude Code using Fable 5.1