You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Revert "feat: first version of aisix-controller" - #3
* feat: add ProviderKey, Model and APIKey custom resource types
* feat: generate structural CRD schemas from aisix-core
* feat: render custom resources into resources-file entries
* feat: validate the resources file with the gateway's own pipeline
* feat: add the reconcile loop and CLI
* build: add deploy manifests, Dockerfile and Makefile
* test: add the kind-based e2e suite
* ci: run lint, unit tests, CRD drift check and e2e
* docs: add README
No actionable comments were generated in the recent review.
Walkthrough
The PR deletes the AISIX controller’s resource definitions, runtime code, CRD and deployment manifests, build and CI files, documentation, and test assets.
Changes: Controller Removal
Layer / File(s)
Summary
Resource contracts and CRDs src/crd.rs, src/schema.rs, deploy/crds/*
The custom-resource types, schema generation code, CRD manifests, and CRD Kustomization are deleted.
The package manifest, container build, Makefile targets, CI workflow, ignore files, and Kubernetes controller deployment and access manifests are deleted.
This change removes the AISIX controller and its related assets. No concrete defects were identified in the removal. Confirm that nothing outside this repository still depends on the controller image or the CRDs before merging.
Pre-merge checks: 6
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title identifies this as a revert of the initial aisix-controller feature. This matches the removal of its implementation, deployment files, documentation, and tests.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
E2e Test Quality Review
The PR reverts the controller and its E2E tests together. The resulting tree is empty and matches the tree before the reverted commit. No business flow remains to test, and no new code introduces erro…
Security Check
The PR deletes the controller and all other tracked files. It introduces no code matching the listed vulnerability patterns. 1. Sensitive data exposure: No issues found. 2. Unencrypted database secret…
Full details: E2e Test Quality Review
Explanation
The PR reverts the controller and its E2E tests together. The resulting tree is empty and matches the tree before the reverted commit. No business flow remains to test, and no new code introduces error-handling or concurrency risks.
Full details: Security Check
Explanation
The PR deletes the controller and all other tracked files. It introduces no code matching the listed vulnerability patterns. 1. Sensitive data exposure: No issues found. 2. Unencrypted database secrets: No issues found. 3. Authorization bypass: No issues found. 4. Ownership validation: No issues found. 5. TLS and cryptography: No issues found. 6. Shared resource safety: No issues found. 7. Secret reference resolution: No issues found.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Essentials
Run ID: 14b0e418-0fb5-485a-bb32-cd72c04617d9
Commits
Reviewing files that changed from the base of the PR and between d9c8531 and ab2d5c1.
Files ignored due to path filters: 1
Cargo.lock is excluded by !**/*.lock
Files selected for processing: 25
.dockerignore
.github/workflows/ci.yaml
.gitignore
Cargo.toml
Dockerfile
Makefile
README.md
deploy/controller/deployment.yaml
deploy/controller/kustomization.yaml
deploy/controller/rbac.yaml
deploy/crds/apikeys.aisix.api7.ai.yaml
deploy/crds/kustomization.yaml
deploy/crds/models.aisix.api7.ai.yaml
deploy/crds/providerkeys.aisix.api7.ai.yaml
deploy/kustomization.yaml
src/assemble.rs
src/crd.rs
src/lib.rs
src/main.rs
src/reconcile.rs
src/render.rs
src/schema.rs
tests/e2e/manifests/mock-openai.yaml
tests/e2e/manifests/resources.yaml
tests/e2e/run.sh
Files with no reviewable changes: 25
.gitignore
deploy/controller/kustomization.yaml
deploy/kustomization.yaml
deploy/crds/kustomization.yaml
deploy/crds/models.aisix.api7.ai.yaml
tests/e2e/manifests/mock-openai.yaml
.github/workflows/ci.yaml
deploy/crds/providerkeys.aisix.api7.ai.yaml
Makefile
Cargo.toml
tests/e2e/run.sh
src/main.rs
deploy/crds/apikeys.aisix.api7.ai.yaml
src/render.rs
.dockerignore
README.md
src/assemble.rs
tests/e2e/manifests/resources.yaml
deploy/controller/rbac.yaml
src/reconcile.rs
src/lib.rs
src/crd.rs
Dockerfile
deploy/controller/deployment.yaml
src/schema.rs
Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1
Summary by CodeRabbit