Skip to content

TINKERPOP-3095: Provide a path for selecting script engine for traversals in TP4 - #3727

Open
Iryna-Kahamlyk wants to merge 1 commit into
apache:masterfrom
Iryna-Kahamlyk:TINKERPOP-3095
Open

Iryna-Kahamlyk wants to merge 1 commit into
apache:masterfrom
Iryna-Kahamlyk:TINKERPOP-3095

Conversation

@Iryna-Kahamlyk

@Iryna-Kahamlyk Iryna-Kahamlyk commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

JIRA: https://issues.apache.org/jira/browse/TINKERPOP-3095

Summary

g.with_("language", ...) was silently dropped from remote traversals in gremlin-javascript.
DriverRemoteConnection only forwards option keys from a fixed allow-list, and language was missing from it. This adds it, with unit and integration tests.

No change is needed in the other GLVs. Java, Python and .NET already forward language from with() to the request, and Go was fixed on master.

@codecov-commenter

codecov-commenter commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.48%. Comparing base (a28cd1f) to head (1fde96f).
⚠️ Report is 909 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3727      +/-   ##
============================================
+ Coverage     76.35%   77.48%   +1.12%     
- Complexity    13424    15001    +1577     
============================================
  Files          1012     1050      +38     
  Lines         60341    66745    +6404     
  Branches       7075     7994     +919     
============================================
+ Hits          46076    51720    +5644     
- Misses        11548    11817     +269     
- Partials       2717     3208     +491     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Iryna-Kahamlyk
Iryna-Kahamlyk marked this pull request as ready for review October 19, 2026 23:22
@spmallette

Copy link
Copy Markdown
Contributor

For committers - Created PR root bead: tp-hk6h

🤖 Agent assisted comment.

@Cole-Greer Cole-Greer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

VOTE +1 (pending changelog update)

Comment thread CHANGELOG.asciidoc Resolved
@kenhuuu

kenhuuu commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

The original issue is already solved in Java, Python, .NET, and Go: g.with("language", ...) is extracted into the request options. Adding connection-level defaults across every GLV is unnecessary and creates inconsistent transaction behavior: Java, Python, .NET, and Go drop the default when creating a transaction-bound connection, while JavaScript preserves it. Users would therefore get different engines for equivalent transactional traversals depending on the GLV.

Please reduce this PR to:

  • Add language to JavaScript’s traversal-option allowlist.
  • Add focused JavaScript tests.
  • Update documentation only as needed for traversal-level selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants