Repository navigation
TINKERPOP-3095: Provide a path for selecting script engine for traversals in TP4 - #3727
Iryna-Kahamlyk wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3727 +/- ##
============================================
+ Coverage 76.35% 77.48% +1.12%
- Complexity 13424 15001 +1577
============================================
Files 1012 1050 +38
Lines 60341 66745 +6404
Branches 7075 7994 +919
============================================
+ Hits 46076 51720 +5644
- Misses 11548 11817 +269
- Partials 2717 3208 +491 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
For committers - Created PR root bead: tp-hk6h 🤖 Agent assisted comment. |
0023038 to
5bafd49
Compare
Cole-Greer
left a comment
There was a problem hiding this comment.
LGTM
VOTE +1 (pending changelog update)
|
The original issue is already solved in Java, Python, .NET, and Go: Please reduce this PR to:
|
88424ea to
aeb1dd6
Compare
aeb1dd6 to
1fde96f
Compare
JIRA: https://issues.apache.org/jira/browse/TINKERPOP-3095
Summary
g.with_("language", ...)was silently dropped from remote traversals ingremlin-javascript.DriverRemoteConnectiononly forwards option keys from a fixed allow-list, andlanguagewas missing from it. This adds it, with unit and integration tests.No change is needed in the other GLVs. Java, Python and .NET already forward
languagefromwith()to the request, and Go was fixed on master.