Repository navigation
[OPENJPA-3028] Fix SUBSTRING without length beyond the string on SQL Server - #284
Merged
Merged
Conversation
…Server SUBSTRING(s, start) used LEN(s) - (start - 1) as length, which is negative when start is beyond the string and fails on SQL Server. Use DATALENGTH(s), which also keeps trailing blanks.
cristof
approved these changes
Nov 7, 2026
solomax
approved these changes
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUBSTRING(s, start) computed its length as
LEN(s) - (start - 1), which is negative for a start beyond the string ("Invalid length parameter passed to the LEFT or SUBSTRING function"). It now usesDATALENGTH(s), which also keeps trailing blanks.Fixes
TestEJBQLFunction.testSubstringBeyondStringon SQL Server, reported in #283.