Repository navigation
Conversation
|
Hi @ppkarwasz |
|
@ppkarwasz |
|
The reason for the versioned file is to allow users to find the threat model of an older version on our website. If we add a new security property in a future version, we don't want reporters to report CVEs against older versions that didn't make that promise. What do you think, should we have a single file and manage changes via “Since version 1.2.3”? |
|
"The reason for the versioned file is to allow users to find the threat model of an older version on our website." |
| - **Family group:** parsers / format readers. | ||
| - **Typical untrusted-input surface:** | ||
| encoded text passed to decoders | ||
| (Base16, Base32, Base58, Base64, Hex, `BinaryCodec`, |
There was a problem hiding this comment.
@ppkarwasz
Sometimes class names are styled, sometimes they're not. This should be consistent. Has anyone actually read this?
|
|
||
| - **Kind:** a low-level building block. | ||
| `DigestUtils` and `HmacUtils` decorate the JCA (`MessageDigest`, `Mac`), | ||
| so the JDK-parity principle applies to them directly. |
There was a problem hiding this comment.
applies to them directly
This hints that "the JDK-parity principle" would apply elsewhere "indirectly". What does that even mean?
| so the JDK-parity principle applies to them directly. | ||
| - **Family group:** parsers / format readers. | ||
| - **Typical untrusted-input surface:** | ||
| encoded text passed to decoders |
There was a problem hiding this comment.
Sentences start with a capital letter but there are not even complete sentences :(
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
I added comments in and out of the "review". This pile of characters is frustrating.
|
|
||
| ## Profile | ||
|
|
||
| - **Kind:** a low-level building block. |
There was a problem hiding this comment.
What does that even mean for an LLM? How many levels are there? Why not just point to the POM description?
| - **Kind:** a low-level building block. | ||
| `DigestUtils` and `HmacUtils` decorate the JCA (`MessageDigest`, `Mac`), | ||
| so the JDK-parity principle applies to them directly. | ||
| - **Family group:** parsers / format readers. |
There was a problem hiding this comment.
What's the difference between a "parser" and a "format reader". A "parser" is a well-know term. I've never seen "format reader", it looks like made up term.
|
|
||
| ### Blake3 | ||
|
|
||
| `Blake3` is a pure-Java implementation of the BLAKE3 hash, keyed hash and KDF. |
There was a problem hiding this comment.
If this is in the Javadoc, we should point to the Javadoc, otherwise ALL of this redundant text will slowly drift away.
This proposes how to implement the Apache Commons umbrella threat model in Commons Codec and applies it to Codec 1.23.0.
Do we want to apply this threat model to earlier Codec versions too?