Repository navigation
First VM deployment double-counts template size in storagepoolhasenoughspace - #14442
Open
sathvikaragi wants to merge 1 commit into
Open
sathvikaragi wants to merge 1 commit into
sathvikaragi wants to merge 1 commit into
Conversation
…mplate size (#125) template size is counted twice when calculating the minimum primary storagepool size required <img width="2196" height="902" alt="image" src="https://github.com/user-attachments/assets/009bc45f-4375-41f7-ae1c-90edca683a87" /> ### Description storagePoolHasEnoughSpace accepts a pool when allocatedSizeWithTemplate + totalAskingSize fits. On the first VM deploy from a template onto a managed pool, the template size was added on both sides. For a root volume, the method passes the template into getAllocatedPoolCapacity, which stored it in allocatedSizeWithTemplate. It then adds the volume size and getAskingSizeForTemplateBasedOnClusterAndStoragePool into totalAskingSize. That second call returns the template size again from getBytesRequiredForTemplate when the pool is managed and clusterId is set. The check asked for used bytes + volume size + 2 × template size. Managed pools now return only getUsedBytes from getAllocatedPoolCapacity. The template is reserved once, in totalAskingSize. This extra add came from Dell's PowerFlex PR.Before that, a managed pool contributed only getUsedBytes to allocatedSizeWithTemplate. This PR... <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [X] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [X] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? ISCSI VM creation , allocated size get's only used bytes of pool for first time VM creation <img width="1403" height="272" alt="Screenshot 2026-10-15 at 6 52 45 PM" src="https://github.com/user-attachments/assets/3d862c7b-a8fe-472c-9857-29003284cb22" /> NFS VM creation , allocated size get's only used bytes of pool for first time VM creation <img width="1402" height="358" alt="Screenshot 2026-10-15 at 8 37 29 PM" src="https://github.com/user-attachments/assets/88bdca34-3144-45f2-a081-4f864a48ed39" /> <img width="1453" height="271" alt="Screenshot 2026-10-15 at 8 38 43 PM" src="https://github.com/user-attachments/assets/7b3635c5-d1df-4cf2-b38b-71dce915410e" /> BOTH NFS AND ISCSI POOLS WERE MADE OF 18 GB and succeeded <img width="1517" height="118" alt="Screenshot 2026-10-15 at 8 38 52 PM" src="https://github.com/user-attachments/assets/ba7607d6-c176-4216-88ab-3b934c5df549" /> <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
sathvikaragi
marked this pull request as ready for review
October 20, 2026 06:21
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
template size is counted twice when calculating the minimum primary storagepool size required for managed pools
Fixes : #14444
Description
storagePoolHasEnoughSpace accepts a pool when allocatedSizeWithTemplate
During Vm creation,storagepoolhasenoughspace is called which then calls the method getAllocatedPoolCapacity, which fetched the used bytes and template size stored it in allocatedSizeWithTemplate. It then adds the volume size and
getAskingSizeForTemplateBasedOnClusterAndStoragePool into totalAskingSize. That second call returns the template size again from getBytesRequiredForTemplate when the pool is managed and clusterId is set. This leads to getting total required size as used bytes + volume size + 2 × template size.
Managed pools now return only getUsedBytes from
getAllocatedPoolCapacity. The template is reserved once, in totalAskingSize. This extra add came from Dell's PowerFlex PR.Before that, a managed pool contributed only getUsedBytes to allocatedSizeWithTemplate.
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
ISCSI VM creation , allocated size get's only used bytes of pool for first time VM creation
NFS VM creation , allocated size get's only used bytes of pool for first time VM creation
How did you try to break this feature and the system with this change?