Skip to content

make sure pre saml login is enabled after saml is disabled - #13953

Open
DaanHoogland wants to merge 4 commits into
mainfrom
ghi12595-saml-disable-ldap-fallback
Open

make sure pre saml login is enabled after saml is disabled#13953
DaanHoogland wants to merge 4 commits into
mainfrom
ghi12595-saml-disable-ldap-fallback

Apply batched suggestions from code review

a35ca41
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Oct 21, 2026 in 3m 38s

Quality Gate passed

Issues
22 New issues
0 Accepted issues

Measures
0 Security Hotspots
72.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 101 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "@Override" annotation above this method signature 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa67&open=AaFYkkamW2CgW25WJa67&pullRequest=13953

Check warning on line 97 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa66&open=AaFYkkamW2CgW25WJa66&pullRequest=13953

Check warning on line 310 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa7E&open=AaFYkkamW2CgW25WJa7E&pullRequest=13953

Check warning on line 167 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa7B&open=AaFYkkamW2CgW25WJa7B&pullRequest=13953

Check warning on line 159 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa6_&open=AaFYkkamW2CgW25WJa6_&pullRequest=13953

Check warning on line 142 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa68&open=AaFYkkamW2CgW25WJa68&pullRequest=13953

Check warning on line 147 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa69&open=AaFYkkamW2CgW25WJa69&pullRequest=13953

Check warning on line 315 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa7H&open=AaFYkkamW2CgW25WJa7H&pullRequest=13953

Check warning on line 127 in plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkhSW2CgW25WJa7O&open=AaFYkkhSW2CgW25WJa7O&pullRequest=13953

Check warning on line 317 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "times". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa7J&open=AaFYkkamW2CgW25WJa7J&pullRequest=13953

Check warning on line 330 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa7L&open=AaFYkkamW2CgW25WJa7L&pullRequest=13953

Check warning on line 312 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa7F&open=AaFYkkamW2CgW25WJa7F&pullRequest=13953

Check warning on line 312 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "times". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa7G&open=AaFYkkamW2CgW25WJa7G&pullRequest=13953

Check warning on line 262 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa7D&open=AaFYkkamW2CgW25WJa7D&pullRequest=13953

Check warning on line 323 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa7K&open=AaFYkkamW2CgW25WJa7K&pullRequest=13953

Check warning on line 152 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa6-&open=AaFYkkamW2CgW25WJa6-&pullRequest=13953

Check warning on line 74 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "spy". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa65&open=AaFYkkamW2CgW25WJa65&pullRequest=13953

Check warning on line 350 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa7M&open=AaFYkkamW2CgW25WJa7M&pullRequest=13953

Check warning on line 231 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa7C&open=AaFYkkamW2CgW25WJa7C&pullRequest=13953

Check warning on line 482 in plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkhSW2CgW25WJa7N&open=AaFYkkhSW2CgW25WJa7N&pullRequest=13953

Check warning on line 317 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa7I&open=AaFYkkamW2CgW25WJa7I&pullRequest=13953

Check warning on line 165 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaFYkkamW2CgW25WJa7A&open=AaFYkkamW2CgW25WJa7A&pullRequest=13953
View more details on SonarQubeCloud