Repository navigation
Conversation
Each chunk of a CLOB is encoded to UTF-8 on its own, so a character outside the BMP split between two chunks was encoded as "??". A chunk that ends with a high surrogate now leaves it for the next chunk, and the read position advances by the characters actually read.
jbonofre
requested review from
laurentgo,
lidavidm and
wgtmac
as code owners
November 15, 2026 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Follow-up to #1231.
ClobConsumerreads a CLOB in chunks of 256 characters and encodes each chunk to UTF-8 on its own, so a character outside the BMP split between two chunks was encoded as??.SQLExceptioninstead of looping forever.ClobConsumerTestcovers emojis across chunk boundaries for both consumers. The test fails without the fix: 255afollowed by 😀 read back as 257 bytes instead of 259.This changes other lines of
ClobConsumerthan #1479, and the two branches merge cleanly.Closes #1478.