Repository navigation
GH-1469: Infer the allocation manager from the factory found on the classpath - #1470
Merged
Merged
Conversation
… the classpath CheckAllocator now looks up each known DefaultAllocationManagerFactory and returns the one it found, instead of guessing from the location name. It warns when several allocation manager types are on the classpath, and logs the inferred type (Netty/Unsafe) with its location on a single line. Closes apache#1469.
jbonofre
requested review from
laurentgo,
lidavidm and
wgtmac
as code owners
November 13, 2026 04:31
lidavidm
approved these changes
Nov 13, 2026
lidavidm
left a comment
Member
There was a problem hiding this comment.
LGTM, just needs to be formatted
lidavidm
approved these changes
Nov 13, 2026
raulcd
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Follow-up to #1461. When no allocation manager type is set,
CheckAllocator.check()used to pick the factory class by searching the resource location formemory-core,memory-unsafeormemory-netty. It now looks up each knownDefaultAllocationManagerFactoryresource and returns the factory it actually found:memory-coreis no longer inferred as the memory-core test factory.Netty/Unsafename accepted byarrow.allocation.manager.typeand the full location:With both Unsafe and Netty on the classpath:
TestCheckAllocatorcovers the inference with a class loader serving resources from chosen locations.Closes #1469.