Repository navigation
Add unit test case for GarbageCollectionAlgorithm.makeRelative() - #6643
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5
ddanielr
approved these changes
Nov 10, 2026
ddanielr
left a comment
ddanielr
left a comment
Contributor
There was a problem hiding this comment.
Seems fine to me.
This code gets removed on merge to main anyway.
dlmarion
approved these changes
Nov 10, 2026
dlmarion
left a comment
dlmarion
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but you are going to have an issue on the merge to main because #6616 was merged. See https://github.com/apache/accumulo/pull/6616/changes#diff-5044a3b0f3aa93923a34df7c41e2ca67b6271dbb3c26f4cd7d5020f1150af491
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
testMakeRelativetoGarbageCollectionTestwith direct unit tests formakeRelative(String, int). To make it testable, the method is now package-private and marked@VisibleForTesting.Covers:
tableId/tabletDir[/file], including a leading../or/, trailing slashes, empty components, andb-/B-bulk dirsexpectedLen(file asked for as a dir, and the reverse)tablesmissing or out of place, and colons in short pathsCo-Authored-By: Claude Opus 5.5