Repository navigation
fix dep service version - #379
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The actuator configuration can reject dependency tasks under ordinary concurrent load, causing the intended tolerant endpoint to return an error for the whole dependency section.
1 open issue
What changed in this PR
Updates dependency-service version reporting so /manage/info fetches current service metadata on every request rather than returning cached values. The aggregation now performs concurrent, timeout-bounded fetches with partial-result handling.
Changes:
- Removes
InfoCacheusage and fetches metadata per call from dependency services. - Adds concurrent Actuator dependency-info aggregation with timeout handling.
- Expands tests for refreshes, failures, missing values, retries, and slow services.
| File | Description |
|---|---|
| server/src/test/java/au/org/aodn/ogcapi/server/core/service/ApplicationInfoTest.java | Tests uncached application metadata retrieval, retries, and detection of updated service versions. |
| server/src/test/java/au/org/aodn/ogcapi/server/core/configuration/ActuatorConfigInfoTest.java | Tests dependency aggregation, refreshes, failures, missing values, and timeout behavior. |
| server/src/main/java/au/org/aodn/ogcapi/server/core/service/indexer/EsIndexer.java | Updates indexer metadata retrieval to fetch current application information on each call. |
| server/src/main/java/au/org/aodn/ogcapi/server/core/service/geonetwork/Geonetwork.java | Updates GeoNetwork metadata retrieval to fetch current application information on each call. |
| server/src/main/java/au/org/aodn/ogcapi/server/core/service/dda/DdaService.java | Updates DDA metadata retrieval to fetch current application information on each call. |
| server/src/main/java/au/org/aodn/ogcapi/server/core/service/das/DasService.java | Updates DAS metadata retrieval to fetch current application information on each call. |
| server/src/main/java/au/org/aodn/ogcapi/server/core/service/ApplicationInfo.java | Replaces cached metadata access with per-call application information retrieval. |
| server/src/main/java/au/org/aodn/ogcapi/server/core/configuration/ActuatorConfig.java | Adds concurrent, timeout-bounded dependency metadata aggregation for the management information endpoint. |
Review effort: Lite
Comment on lines
+53
to
+55
| protected static final ExecutorService INFO_EXECUTOR = new ThreadPoolExecutor( | ||
| 0, 16, 60L, TimeUnit.SECONDS, | ||
| new SynchronousQueue<>(), |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.