Repository navigation
Support class-level @CustomFilter annotations in TestRequestBuilder. - #2515
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
piper_1001660089
branch
4 times, most recently
from
October 21, 2026 16:04
b967022 to
eedf186
Compare
Previously, `TestRequestBuilder.CustomFilters` only inspected annotations directly on the test method via `Description.getAnnotations()`, ignoring `@CustomFilter` annotations applied at the test class level. Include class-level annotations from `Description.getTestClass()` when evaluating custom filters, skipping any class annotation whose type is already present on the test method so that method-level overrides do not invoke the same filter twice. PiperOrigin-RevId: 1003995266
copybara-service
Bot
force-pushed
the
piper_1001660089
branch
from
October 21, 2026 16:21
eedf186 to
edea994
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support class-level @CustomFilter annotations in TestRequestBuilder.
Previously,
TestRequestBuilder.CustomFiltersonly inspected annotations directly on the test method viaDescription.getAnnotations(), ignoring@CustomFilterannotations applied at the test class level.Include class-level annotations from
Description.getTestClass()when evaluating custom filters, skipping any class annotation whose type is already present on the test method so that method-level overrides do not invoke the same filter twice.