Repository navigation
Conversation
lwasser
force-pushed
the
readme-failures
branch
3 times, most recently
from
November 11, 2026 01:48
24be881 to
02dfe31
Compare
lwasser
marked this pull request as ready for review
November 11, 2026 02:51
Member
Author
|
This is ready for review! Here I focused on various errors a user may encounter running initial commands so it looks at things like malformed json, bad config, missing readme, etc etc. i also added some friendlier messaging around errors and checked those in our tests too. I think the next round of tests will be related to mocking. i haven't been tracking these with issues but I will start doing that now. |
lwasser
commented
Nov 11, 2026
Contributor
|
This will need to be rebased, following the re-organization of ci jobs. |
lwasser
force-pushed
the
readme-failures
branch
from
November 11, 2026 17:26
6052f68 to
644e737
Compare
Member
Author
|
@michaelfaith rebase is complete! thanks! |
lwasser
changed the title
test: add await so error reach CLI error handler and throw proper returns chore: lint ci: add e2e to ci test: add test and cleaner message for when json file is missing test: cleanup unit test to check for UserError and match message
lwasser
force-pushed
the
readme-failures
branch
from
November 11, 2026 22:10
644e737 to
0a74580
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds e2e tests for points of failure when config files like the json file don't exist. here we raise a UserError and make the unit tests associated with it a bit more explicit too. this pr is built on #616 #617 .