Skip to content

SCIX-972 fix(search): raise the slow-search notice threshold to 15s - #984

Open
thostetler wants to merge 1 commit into
adsabs:masterfrom
thostetler:fix/scix-972-slow-search-notice-threshold
Open

thostetler wants to merge 1 commit into
adsabs:masterfrom
thostetler:fix/scix-972-slow-search-notice-threshold

Conversation

@thostetler

Copy link
Copy Markdown
Member

The slow-search notice fired after 5 seconds on ordinary searches.

  • Threshold is now 15s, half the 30s search API timeout, and overridable via NEXT_PUBLIC_SLOW_SEARCH_THRESHOLD_MS
  • Notice copy now reads "Still searching — large or complex queries can take a while."

Extract the timer into useSlowSearchNotice, overridable via
NEXT_PUBLIC_SLOW_SEARCH_THRESHOLD_MS. The notice copy now reads
"Still searching — large or complex queries can take a while."
@github-actions

Copy link
Copy Markdown
Contributor

Bundle size

Shared by all pages: 632.6 kB (+0.0 kB) ⚪

No route changed by more than 1 kB. ✅

First load = polyfills + shared _app chunks + route chunks, gzipped.

@codecov

codecov Bot commented Nov 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.5%. Comparing base (2a6c3d3) to head (36e7ea2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #984     +/-   ##
========================================
+ Coverage    57.2%   57.5%   +0.3%     
========================================
  Files         402     401      -1     
  Lines       12512   12497     -15     
  Branches     2816    2811      -5     
========================================
+ Hits         7147    7175     +28     
+ Misses       4691    4650     -41     
+ Partials      674     672      -2     
Files with missing lines Coverage Δ
src/config.ts 96.8% <100.0%> (+0.2%) ⬆️
src/lib/useSlowSearchNotice.ts 100.0% <100.0%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thostetler
thostetler marked this pull request as ready for review November 21, 2026 03:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant