Repository navigation
SCIX-952 fix(libraries): send applied filters with add/remove-by-query - #983
Merged
thostetler merged 1 commit intoNov 20, 2026
Conversation
Add/remove-by-query sourced the payload from the debounced search-bar query and sent only q, so biblib acted on the entire unfiltered result set. One handler backs add-to-existing, add-to-new, and remove-by-query, so all three were affected. Now reads the submitted query and builds fq from the resolved getFQs() clauses plus any raw fq clause without an fq_ companion, dropping blank clauses and omitting fq entirely when there are none.
Contributor
Bundle sizeShared by all pages: 632.6 kB (-0.0 kB) ⚪ No route changed by more than 1 kB. ✅ First load = polyfills + shared |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #983 +/- ##
========================================
+ Coverage 57.2% 57.3% +0.2%
========================================
Files 402 401 -1
Lines 12512 12513 +1
Branches 2816 2813 -3
========================================
+ Hits 7147 7163 +16
+ Misses 4691 4678 -13
+ Partials 674 672 -2
🚀 New features to boost your workflow:
|
thostetler
marked this pull request as ready for review
November 19, 2026 20:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Add all" with no selection sent only the search text to biblib, dropping every applied filter and adding the entire unfiltered result set to the library.