Repository navigation
feat(legacy): resolve BBB hash routes on the client - #982
Open
thostetler wants to merge 4 commits into
Open
thostetler wants to merge 4 commits into
thostetler wants to merge 4 commits into
Conversation
Bumblebee put the route after the hash (#abs/<bibcode>/metrics), and a fragment never reaches the server, so every one of these links landed on the home page instead of the record. LegacyHashRedirect parses the hash client-side and replaces the location; a pre-hydration script in _document hides the page and shows "This link has moved..." in the meantime, clearing itself after 6s regardless.
/search/q=foo/metrics redirected to plain /search and dropped the /metrics sub-route, and p_ (BBB's zero-based page index) passed through unmodified instead of becoming the 1-based p param the app reads. It now also recognizes BBB's show-* and export-* suffixes, translating them to the same sub-routes the hash-based redirect uses.
Bumblebee called this view figures; a direct link to /abs/:id/figures 404ed without this redirect.
thostetler
marked this pull request as ready for review
November 19, 2026 05:37
Contributor
Bundle sizeShared by all pages: 634.0 kB (+1.4 kB) 🔴
…and 22 more routes changed. First load = polyfills + shared |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #982 +/- ##
========================================
+ Coverage 57.2% 57.6% +0.5%
========================================
Files 402 405 +3
Lines 12512 12648 +136
Branches 2816 2849 +33
========================================
+ Hits 7147 7285 +138
+ Misses 4691 4688 -3
- Partials 674 675 +1
🚀 New features to boost your workflow:
|
Contributor
|
❌ E2E Tests Failed 🎭 Some E2E tests failed. 📎 Test artifacts are available in the workflow run |
shinyichen
approved these changes
Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy Bumblebee links put the route after a # (e.g. #abs//metrics),
which browsers never send to the server, so these links landed on the home
page instead of the record. They now resolve client-side, with a brief
"This link has moved" notice while the redirect runs.
and ignored BBB's p_ page index; both now carry through correctly.