Repository navigation
Text fields draw no focus ring (0.3.1) - #19
Merged
Merged
Conversation
Sami, 14 Nov: the focus ring on input boxes is ugly and has to go, in the kit so it reaches every site. Fields (input, textarea, select) lose the outline and ring shadow at zero specificity; buttons and links keep theirs. 0.3.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sami, 14 Nov: the focus ring on input boxes is ugly and has to go. It should be removed in the kit so the change reaches every site.
What changed (
src/kit.css):where(input, textarea, select)getsoutline: none; box-shadow: noneon:focusand on:focus-visible. The selector has zero specificity, so a site can still style its own fields on purpose. The caret shows where you're typing.:focus-visiblering for buttons and links, so keyboard users still see where they are. Their fields no longer get it..ak-search, the menu's search box, now has the quiet--ak-edgeborder. It used to have the--ak-accentborder, which looked like a focus ring at all times.Tests:
tests/focus.test.mjschecks the rules indist/kit.css.npm testpasses 36, fails 0, andnpm run typecheckpasses.src/kit.cssput back:npm testfails the 3 new tests (pass 33, fail 3).After merging,
v0.3.1gets tagged to publish. Every site using the kit is then bumped, and in the same bump any site that draws its own ring on its fields (staff.addis.gg does) drops that rule.-claude
🤖 Generated with Claude Code
https://claude.ai/code/session_01PX7GLxjF7DzhnQ2ZvFi6Sq