Repository navigation
The license, once: MIT text, footer line, hero badge and license page (APS 17, 0.3.0) - #17
Merged
Merged
Conversation
… from one License (APS 17) (0.3.0) mitLicense() builds the LICENSE file's text byte for byte (tested against harar's and p8's files, upstream notices kept above ours); LicenseLink, LicenseBadge and LicenseView show it. A source link appears only when a site passes one. The tool header's links wrap at phone width.
… the MIT licensed badge is gone
…e a site's link colours
…te-aps17 # Conflicts: # package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Addis products are MIT (APS 17, addiscorp/aps#17). This puts the license in the kit once, so every site shows it the same way:
License: one description of a product's license:year(2026),holder(Sami Fouad), optionalgithubhandle,upstreamnotices a fork arrived with, aprefaceline,source(public repositories only),href(/license/).mitLicense(license): the LICENSE file's text, byte for byte.MIT_LICENSEis the default (Copyright (c) 2026 Sami Fouad). Upstream notices stay above ours (p8: Di Wu, then Sami Fouad).licenseprop →MIT · © 2026 Sami Fouad(Sami's call: "MIT", not "MIT License"), linking to/license/, then· sourceonly whensourceis passed.ToolSiteandDocsLayoutpass it through.Hero'sstatus('alpha' | 'beta') andlicenserender as two pills of one shape, side by side above the buttons: ( Status: Alpha | Beta ) ( License: MIT ). Both have the same height, font and dot, with the value in bold. Beta has a filled dot and alpha a hollow one, in the site's accent, light and dark. The License pill links to/license/. Per Sami's review, the pills carry only that text (no notes), and the earlier "✓ MIT licensed" badge (LicenseBadge) is removed.ProductPillsrenders the pair on any page;StatusPill,LicensePill,statusTextandLICENSE_PILL_TEXTare its parts. This replaces Hero's free-textstatusstring, which is fine because 0.3.0 isn't published yet. Tests:tests/status.test.mjs.LicenseView: the page: a heading, "<product>is MIT licensed: use it, change it, ship it, commercially or not; keep the notice.", an optionalnote(a part under another license), the source when public, and the full text in monospace at a readable width, in the site's--ak-*colours, light and dark. On a phone each paragraph reflows instead of keeping the file's 80-column breaks; the DOM text is still the file's, byte for byte.source. Tested.npm version minor --no-git-tag-version; no tag). README has a "The license" section.Why
APS 17 relicenses the products to MIT and Sami wants the sites to show it proudly. AGENTS.md §3: if two artifacts must agree, share one function. The footer, badge, page and LICENSE text all come from one
Licensevalue.Evidence
CI (
.github/workflows/ci.yml), run locally:tests/fixtures/harar-LICENSEis addiscorp/hararclaude/mit-license-aps17(PR #107), sha25620ba8463…a999.tests/fixtures/p8-runtime-LICENSEis p8runtime/runtime main, sha2561ee77bc7…3296. addiscorp/p8-test-suite's LICENSE on main is byte-identical toMIT_LICENSEtoo.Proof the test bites: with
'MIT License'changed to'MIT License 'inmitLicense,npm test→ exit 1, 3 failing (both byte-for-byte tests and the p8 page test). Reverted.Screenshots of the kit pieces on all nine sites (light/dark, desktop/phone) are under
/Volumes/Projects/claude/license-sites/kit-agent/shots/<site>/on the iMac.After merge
The sites' PRs pin
@addiscorp/kit0.3.0, which needs this tagged (v0.3.0) and published by publish.yml. Their CI fails until then; that's expected. Ava handles the tag.Not changed here: kit's own
LICENSEand"license": "Apache-2.0"in package.json (the relicensing PRs own those).-claude