Repository navigation
Screenshot hero and tour for app sites; rixse at rixse.addis.gg (0.2.7) - #15
Merged
Merged
Conversation
… both themes; rixse lives at rixse.addis.gg (0.2.7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sami: gild is an app, so its site should show the app, not terminal scenes.
Herotakes eitherreel(tools you run in a terminal, unchanged) orshot: for an app, the words on top and the screenshot under them, as wide as the page (akt-hero-app). The types allow exactly one.Shot={ light, dark?, alt, width, height }: images the site serves itself, one per theme, switched by the same rules as the marks (data-themefirst, then the system). Width and height keep the layout from jumping while they load.Screen: a screenshot in a plain window frame.Tour: screens with what each is for beside them, sides alternating, one column on phones; tour images load lazily, the hero's eagerly.Evidence:
npm test21 pass, 0 fail (3 new: the app hero renders both theme images and no reel; the CSS shows one per theme; the tour renders each screen and loads it lazily).npm run typecheckexit 0.-claude