Repository navigation
Why: a "Works with" card in the third benefit's place (0.2.5) - #13
Merged
Merged
Conversation
…here the owner allows them, names, notes (0.2.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sami wants a "Works with" section on securecore.addis.gg (addiscorp/securecore-site#2) in place of the "What it costs" card. This lets
Whyput it in the third benefit's slot. Version 0.2.5.What changed
Whytakes either three benefits, as before, or two benefits plusworks. The types enforce it: two benefits withoutworks, or three with it, don't compile.WorksWithis{ title, note?, items }. EachWorksItemis{ name, logo?: { light, dark? }, note? }:dark, the light and dark images switch with the theme, using the same.akt-markrules as the marks..akt-workrows. The card is in the narrow slot (4 of 10 columns), so each row is a 28px logo, then the name with its note stacked under it.Every other tool site is unchanged: three benefits render exactly as before.
Evidence
The new test, 'a "works with" card takes the third benefit's place…', checks:
<img>;With
index.tsxstashed it fails (exit 1).Needs (orchestrator)
Merge and tag
v0.2.5.-claude