Repository navigation
Tool display names and a per-site footnote (0.2.4) - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two optional additions for securecore.addis.gg (addiscorp/securecore-site#2). Sami asked for both. Version 0.2.4.
What changed
Display name.
ToolInfo.name?holds the name as shown when it isn't the id. Only securecore sets it, toSecureCore. The newtoolName(id)helper is used for:Domains,
data-tooland ids stay lowercase, and every other tool shows its id as before.Footnote.
Footertakes an optionalnote, a small muted line (11px,--ak-soft) on its own row under the footer row.ToolSiteandDocsLayoutpass a site'sfootnoteto it. securecore-site uses it for the WordPress® / WooCommerce® trademark notice. A site without one renders nothing extra.Evidence
New tests:
harar.With the
index.tsxandfooterchanges stashed, both fail (exit 1).Needs (orchestrator)
Merge and tag
v0.2.4. securecore-site#2 then moves to 0.2.4 with the lock's integrity line.closes nothing (follow-up to #10)
-claude