Repository navigation
ci: move checkout and setup-node to v7, pinned to commit SHAs - #6
Merged
Merged
Conversation
The v4 actions run on Node 20, which GitHub deprecated. v7 runs on Node 24. The publish job drops the npm dependency cache, as setup-node recommends for OIDC publishing: a poisoned cache could reach the token. CI keeps its cache.
Tags can be moved; a commit SHA cannot. Each pin keeps its version as a comment, and Dependabot (github-actions, weekly) bumps both together.
a-tokyo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every run warns that
actions/checkout@v4andactions/setup-node@v4target Node 20, which GitHub deprecated.What
actions/checkoutv4 → v7 andactions/setup-nodev4 → v7 inci.ymlandrelease.yml.The release
publishjob now setspackage-manager-cache: falseand no longer usescache: npm. setup-node's Trusted Publisher (OIDC) docs recommend this: a poisoned cache could reach the OIDC token. CI keepscache: npm.Actions are pinned to full commit SHAs (
checkoutv7.0.13d3c42e,setup-nodev7.1.0949feb2), with the version as a comment. Tags can be moved, SHAs cannot.New
.github/dependabot.yml(github-actions, weekly) keeps the pins and their comments current.Breaking changes checked
packageManageris set. This repo doesn't set it.NODE_AUTH_TOKENexport. OIDC publishing doesn't use that token.Testing
release.yml, so Release runs onmain.v0.1.6is already tagged, socheckshould skip publish and release.🤖 Generated with Claude Code