Repository navigation
Fixed potential errors on the mod browser that copilot caught when reviewing code on PR #80 - #82
Merged
Conversation
KhromeHearts
commented
Oct 18, 2026
KhromeHearts
commented
Contributor
- Follow up fixes based on Copilot’s review of my last PR
- Mods that aren’t NeoModLoader mods are now rejected instead of being marked as installed
- Fixed list/browser refresh issues after downloads or reloads
- Fixed Workshop descriptions disappearing unexpectedly after being viewed once
- Fixed thumbnail images getting removed while still visible
- Small Mod Browser and UI fixes (tab/window behavior and dependency updates after deleting a mod)
- Tiny tweaks to the ReadME
Updated README to emphasize subscribing for updates.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Stale declaration references can break mod-info actions, inactive rows retain thumbnails, and updated mods can lose their Workshop URL.
3 open issues
What changed in this PR
Follow-up fixes improve the Mod Browser’s download handling, refresh behavior, and thumbnail retention within NeoModLoader.
Changes:
- Reject unsupported mods and update installation and dependency state.
- Improve browser refreshes, thumbnail ownership, and Workshop query cleanup.
- Correct list-window initialization and adjust README presentation.
| File | Description |
|---|---|
| utils/WorkshopThumbnails.cs | Protect owned thumbnails from eviction. |
| ui/prefabs/ModBrowserRow.cs | Register thumbnail ownership per row. |
| ui/ModBrowserWindow.cs | Guard trending loads and refresh download status. |
| services/ModWorkshopServiceWindows.cs | Dispose description query results. |
| services/ModWorkshopServiceUnix.cs | Dispose description query results. |
| services/ModManagerService.cs | Rebuild dependencies after deletion. |
| services/ModDownloadService.cs | Validate mod types and replace unloaded declarations. |
| resources/commit | Update the recorded commit. |
| README.md | Emphasize update guidance and adjust formatting. |
| api/AbstractListWindow.cs | Initialize the window identifier. |
Review effort: Balanced
Comment on lines
+185
to
+186
| WorldBoxMod.AllRecognizedMods.Remove(recognized); | ||
| WorldBoxMod.AllRecognizedMods[mod] = ModInfoUtils.isModDisabled(mod.UID) ? ModState.DISABLED : state; |
| ? current | ||
| : ModState.FAILED; | ||
| WorldBoxMod.AllRecognizedMods.Remove(recognized); | ||
| WorldBoxMod.AllRecognizedMods[mod] = ModInfoUtils.isModDisabled(mod.UID) ? ModState.DISABLED : state; |
| age.text = DescribeAge(DateTime.UtcNow - pListing.Updated); | ||
| thumbnail.sprite = InternalResourcesGetter.GetIcon(); | ||
| WorkshopThumbnails.Request(pListing.PreviewUrl, sprite => | ||
| WorkshopThumbnails.Request(pListing.PreviewUrl, this, sprite => |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.